Conversation
HoneyryderChuck
force-pushed
the
sig-updates
branch
3 times, most recently
from
00a6e6b to
de232cd
Compare
HoneyryderChuck
force-pushed
the
sig-updates
branch
from
de232cd to
fcfee40
Compare
|
|
||
| module HTTP2 | ||
| VERSION = "1.0.2" | ||
| VERSION = "1.1.0" |
There was a problem hiding this comment.
I think version gets bumped automatically with the publisher, doesn't it? I thought I read something about version.rb being assumed.
There was a problem hiding this comment.
it doesn't (and I'm counting on it, as changes in this file trigger the release workflow).
There was a problem hiding this comment.
There was a problem hiding this comment.
https://bundler.io/guides/creating_gem.html#releasing-the-gem
This is what I was thinking of. I guess it's gem bump that could do this. So that can be in the CI if you wanted.
There was a problem hiding this comment.
Not sure if that's the most feasible. You need a way to tell CI that you want to bump the version, and whether it's a patch/minor/major bump. Bumping locally and triggering the release flow on changes to version.rb seems more straightforward.
2 participants
a few last minute signature improvements, and the version + changelog changes.
Testing Trusted Publishing as well through it.