feat: [wip] ordered-float feature options - #492
gechelberger wants to merge 3 commits into
Conversation
|
Thanks for starting this PR. I allowed test actions to run and will apologize in advance for delays in reviewing! |
|
No worries. I think I fixed the feature gates that tripped up CI.
I'm not sure if it's better to just yank Related to #493, normally I would want to resolve that on another PR first and then merge this on top, but I think I'm going to have to restructure |
|
A couple points of interest: QuantityArguments traits: I haven't fully wrapped my head around how they fit into the framework yet and what the correct types should be. NotNan tests NotNan needs its own whole test suite since it panics on a bunch of "reasonable" arbitrary inputs like any negative for sqrt. ConstZero for NotNan ConstZero can't be implemented for NotNan without an unsafe block (which in this context is completly safe) There are definitely other things to sort out, but these are the ones that could most benefit from some input. Thanks! |
Related to issue #208
Working on optional lib features to handle ordered_float wrapper types natively.
This draft is probably 90% of the way there but there are a few design decisions still to make, and a lot of polishing to be done.