Conversation
Dead since Vite 8 tree-shakes unused globs; images are handled by the assets option in vite.config.js and fonts via real url() references in fonts.css. Bump theme version to 2.15.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release removes a vestigial
import.meta.glob(['../images/**', '../fonts/**'])call fromresources/js/app.jsand bumps the theme to version 2.15.4. The glob call became dead code once Vite 8 began tree-shaking unused glob invocations (as documented in the 2.15.3 release), and both asset paths it previously targeted are already handled through supported mechanisms: images via theassetsoption invite.config.js, and fonts via realurl()references inresources/css/fonts.cssthat keep them in the module graph. The change is purely a cleanup with no functional impact, verified against the production build output to confirm all font and image manifest entries remain intact. Documentation and version metadata acrossCHANGELOG.md,readme.txt, andstyle.cssare updated to reflect the 2.15.4 release.Code Cleanup:
import.meta.glob(['../images/**', '../fonts/**'])call at the top ofresources/js/app.js, which stopped emitting assets after the Vite 8 tree-shaking behavior introduced in 2.15.3 and duplicated coverage already provided elsewhere in the build pipeline.npm run buildthat all font and image manifest entries are unaffected, establishing the removal as a no-op with respect to output assets.Version and Documentation Updates:
style.cssand thereadme.txtstable tag to align packaged metadata with the release.CHANGELOG.mdandreadme.txtdocumenting the removal, the rationale tied to the Vite 8 tree-shaking change, and the alternate handling of images (via thevite.config.jsassetsoption) and fonts (via CSSurl()imports).Files Changed:
CHANGELOG.md(Modified)readme.txt(Modified)resources/js/app.js(Modified)style.css(Modified)