Repository navigation
Match coverage files to samples by file name - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parser::fill_upmatched a coverage file to its sample by searching the external id anywhere in the file's path. A short id matched longer names and directory names:mes.all.bwwas taken for samplees, and under a directory calledcores16every file was. A sample matched to the wrong file dropped out of the sample set, so its junctions were not used for stitching and the parser ran fewer threads.The id must now be a whole token of the base name, bounded by non-alphanumeric characters, and the longest matching id wins. Two files naming one sample are reported.
On ten samples named
es,mes,ir,a3,a5,mee,afe,ale,mixed_terminalandmixed_internal: 9 recognised before, 10 after; junction entries on chr19 go from 125,175 to 137,704.Tests:
ctest, 48 pass, three of them new.