-
Notifications
You must be signed in to change notification settings - Fork 16
chore: update game bridge to 2.12.5 #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
platform-sa
wants to merge
13
commits into
main
Choose a base branch
from
chore/update-game-bridge-2.12.5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+434
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImmutableJeffrey
previously approved these changes
Jan 28, 2026
64fdba8 to
3e35681
Compare
Remove unnecessary polyfills and transformations by leveraging UnityWebBrowser 2.2.7 (CEF 137 = Chrome 137) native BigInt support. Changes: - Remove JSBI, whatwg-fetch, Babel polyfills from game-bridge - Replace transform-bigint.js with fixUnityBuild.js - Inline all JS into single script block without code transformations - Update Parcel target to Chrome 137 (current CEF version) - Add Parcel bundler configuration (.parcelrc) - Modify index.html to use external module reference This approach eliminates regex-based code transformations that were corrupting string literals and causing syntax errors.
5ebe614 to
053fbfd
Compare
Change Parcel target from Chrome 137 to Chrome 90 to reduce code-splitting and improve deep link handling reliability. Chrome 90 produces fewer code-split chunks (2 vs 4), reducing timing issues during protocol handler execution and improving compatibility with CEF-based WebView implementations. Benefits: - Fewer dynamic imports = fewer race conditions - Smaller bundle size (1.8 MB vs 2.0 MB) - Better deep link reliability (verified in PR #2781) - Maintains full BigInt and modern JavaScript support
Improvements to Windows test reliability: 1. Disable browser cache to prevent cached session redirects - Add --incognito mode - Set --disk-cache-size=0 - Use temporary user-data-dir for each run 2. Fix protocol handler registration to use actual executable path - Find app using same logic as open_sample_app() - Support UNITY_APP_PATH environment variable - Use absolute path instead of hardcoded path This ensures fresh login flow every test run and proper deep link handling via immutablerunner:// protocol.
Remove --allow-external-protocol-handlers flag which was causing Brave to attempt automatic protocol handling without showing the permission dialog, resulting in silent failures. Now the dialog should appear asking "Open Sample Unity 6 Windows.cmd" which the test can then click to proceed with the deep link.
- Add comprehensive debug logs to game-bridge initialization - Add browser feature detection (BigInt, fetch, Error.cause, etc.) - Add detailed callback logging to track Unity communication - Update Parcel target from Chrome 90 to Chrome 137 to match CEF version - Improves debugging visibility for viem compatibility investigation
28ee3e8 to
83b95c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update game bridge (build from ts-immutable-sdk version 2.12.5)