Skip to content

helium/core: add quoted exact match to find in page - #2760

Closed
finaIcutpro wants to merge 1 commit into
imputnet:mainfrom
finaIcutpro:find-exact-match
Closed

finaIcutpro wants to merge 1 commit into
imputnet:mainfrom
finaIcutpro:find-exact-match

Conversation

@finaIcutpro

Copy link
Copy Markdown

For your pull request to not get closed without review, please confirm that:

  • An issue exists where the maintainers agreed that this should be implemented
    (an approved feature request, or confirmed bug).
  • I tested that my contribution works locally, and does not break anything,
    otherwise I have marked my PR as draft.
  • If my contribution is non-trivial, I did not use AI to write most of it.
  • I understand that I will be permanently banned from interacting with this
    organization if I lied by checking any of these checkboxes.

Tested on (check one or more):

  • Windows
  • macOS
  • Linux

I commonly find it annoying in the default Command + F menu that I can't do exact word matching. This short PR fixes it.

@greptile-apps

greptile-apps Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

RetriggerView in Greptile

[Medium impact] The change affects Find in Page searches across browser pages.

The PR appears safe to merge, with a non-blocking request for regression tests.

Reviews (1) · Last reviewed commit: "add quoted exact match to find in page" · Reviewed by Greptile

Comment on lines +49 to +52
+ if (const auto exact_search = GetExactSearch(find_text_)) {
+ search_text = *exact_search;
+ options->match_case = true;
+ options->whole_word = true;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Quoted searches lack tests

The patch adds quote parsing and changes both match counting and navigation without regression tests. Future changes could make the count disagree with navigation without a test catching it. Add tests for quoted and unquoted searches, missing closing quotes, empty quotes, case differences, and whole-word boundaries. Check both reported counts and next/previous navigation.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant