Repository navigation
helium/core: add quoted exact match to find in page - #2760
finaIcutpro wants to merge 1 commit into
Conversation
|
[Medium impact] The change affects Find in Page searches across browser pages. The PR appears safe to merge, with a non-blocking request for regression tests. Reviews (1) · Last reviewed commit: "add quoted exact match to find in page" · Reviewed by Greptile |
| + if (const auto exact_search = GetExactSearch(find_text_)) { | ||
| + search_text = *exact_search; | ||
| + options->match_case = true; | ||
| + options->whole_word = true; |
There was a problem hiding this comment.
The patch adds quote parsing and changes both match counting and navigation without regression tests. Future changes could make the count disagree with navigation without a test catching it. Add tests for quoted and unquoted searches, missing closing quotes, empty quotes, case differences, and whole-word boundaries. Check both reported counts and next/previous navigation.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
For your pull request to not get closed without review, please confirm that:
(an approved feature request, or confirmed bug).
otherwise I have marked my PR as draft.
organization if I lied by checking any of these checkboxes.
Tested on (check one or more):
I commonly find it annoying in the default Command + F menu that I can't do exact word matching. This short PR fixes it.