Repository navigation
helium/ui/find-bar: add match case and whole word toggles to find menu - #2762
Open
finaIcutpro wants to merge 3 commits into
Open
finaIcutpro wants to merge 3 commits into
finaIcutpro wants to merge 3 commits into
Conversation
|
[Medium impact] The change affects the browser's find-in-page workflow. The PR appears safe to merge, with a non-blocking issue where open windows can overwrite each other's search options. Reviews (1) · Last reviewed commit: "add find in page switches" · Reviewed by Greptile |
Author
|
I have no further changes I want to make && am happy with the code. I believe this is ready to merge. |
Possibly related issuesThese relationships were inferred from the effective change and may need maintainer confirmation:
|
There was a problem hiding this comment.
Found four actionable correctness issues involving cached iframe matches, PDF searches, and shared find-option state.
Review walkthrough
Changes
| Files | Summary |
|---|---|
patches/helium/core/find-exact-match.patch |
Adds whole_word to Mojo find options and forwards it to Blink's active-match and scoping matchers. Reviewed renderer caching and the separate plugin/PDF path. |
patches/helium/ui/find-bar-options.patch |
Adds animated option rows, profile-level matching state, and search-session detection for option changes. Reviewed callbacks, ownership, focus handling, cross-window synchronization, and PDF restarts. |
i18n/source.gen.jsonpatches/series |
Registers three matching UI strings and orders the renderer prerequisite before the UI patch, which follows the existing find-bar patch. |
Review checks
| Check | Result | Notes |
|---|---|---|
| Scope | ✅ Passed | Confirmed four changed repository files and ten effective Chromium targets. No version transition or patch-application warnings; reported locations match reviewable provenance. |
| Project Policy | ✅ Passed | Neither new patch changes upstream tests, test data, expectations, or test targets. |
| Correctness And Safety | Identified stale renderer caches, two PDF integration defects, and unsynchronized shared controls. Reviewed desktop build wiring, lifetime, and incognito service separation. | |
| Chromium Idioms | ✅ Passed | The implementation uses existing Blink whole-word matching, Views builders, toggle controls, and animation APIs. |
| Simplicity And Decomposition | ✅ Passed | The row helper and callbacks have local responsibilities; no separate actionable abstraction or decomposition concern. |
| Patch Organization | ✅ Passed | Renderer support and UI integration are coherent patches, with prerequisites ordered correctly and UI work adjacent to the existing find-bar patch. |
Analysis record
- Changed files considered: 4
- Findings: 4 new, 0 retained, 0 resolved
- Source snapshot:
e5b1aeac84f7 - Codex:
gpt-6.1-sol, reasoningmax, fast mode on, web search cached - Patch application: clean
- Chromium context tool calls: none
- Maintainer conventions applied:
ignore-disabled-telemetry,preserve-incremental-loading,script-resource-lifecycle,ui-command-contexts,validate-supported-ui-paths,verify-runtime-selection-paths,visible-ui-anchors
Limitations
- Static inspection only; builds, tests, and interactive UI validation were not run.
- The supplied screenshots were available, but the PR's video attachment was unavailable.
Author
|
all gardener suggestions have been triaged && resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For your pull request to not get closed without review, please confirm that:
(an approved feature request, or confirmed bug).
otherwise I have marked my PR as draft.
organization if I lied by checking any of these checkboxes.
Tested on (check one or more):
I found it annoying to have to deal with exact word and case sensitive matching in the Cmd + F menu. This fixes that.

Screen.Recording.2026-10-19.at.9.51.37.PM.mov