Open
Conversation
skomorokh
requested review from
adamdickmeiss,
ihardy,
jakub-id and
kurtnordstrom
as code owners
There was a problem hiding this comment.
Pull request overview
Updates how loan conditions are displayed in the Flow view by sourcing them from the broker notifications stream (instead of request.conditions), and ensures the UI refreshes after adding a condition.
Changes:
- Switch loan condition rendering to derive from
broker/patron_requests/:id/notificationsitems ofkind === 'condition'. - Invalidate the notifications query after the “add-condition” action to refresh displayed conditions.
- Increase notifications query limit to 1000 and add the LoanConditions section into the Flow view components list.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/util/formatCondition.js |
Adapts condition formatting helpers to operate on notification-shaped objects (condition, cost, currency, note). |
src/components/chat/useNotifications.js |
Requests notifications with an increased limit to support condition/history display. |
src/components/Flow/moreActions/AddCondition.js |
Invalidates the notifications query after successfully adding a condition. |
src/components/Flow/FlowViewComponents/index.js |
Inserts the LoanConditions section into the Flow view layout. |
src/components/Flow/FlowViewComponents/LoanConditions.js |
Reimplements LoanConditions to fetch and display condition notifications via useNotificationList. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...but still leaves unread messages displayed as unread when you're opening the pane so you get a chance to see what's new
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.