remove redundant rebind peer-peer messages#873
Open
haitaohuang wants to merge 3 commits into
Open
Conversation
The old side no longer sends init_tdinfo as a separate presession packet, and the new side no longer receives or packs it into the return buffer. Also remove the dead init_tdinfo decode from the SPDM rebinding responder (it was parsed then discarded). init_tdinfo is already exchanged via TdReportInit in the SPDM attest-info VDM message and as a TLS cert extension in TLS mode. Signed-off-by: Haitao Huang <haitaohuang@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…d attest-info Stop encoding, parsing, and verifying the MigPolicyInit element (mrowner hash) on the rebind path. Both MigPolicyInit and TdReportInit originate from the same peer in the same message, so the mrowner cross-check has no security value. Decrement rebind-req element count from 6 to 5 and drop the MigPolicyInit enum variant. Signed-off-by: Haitao Huang <haitaohuang@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…sion Rebinding old/new presession exchanges were identical to the migration pre_session_data_exchange. Replace both with a single call to the shared function. The new-side length-prefix wrapping moves inline to the caller. Signed-off-by: Haitao Huang <haitaohuang@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #871 and #872
Also unifies pre-session messages for both rebinding and migration