Response time improvements - #224
Merged
Merged
Conversation
JonatanWaern
force-pushed
the
reduce-workpool-usage
branch
from
June 15, 2026 08:59
5e91469 to
cbb33af
Compare
JonatanWaern
marked this pull request as ready for review
June 15, 2026 08:59
There was a problem hiding this comment.
Pull request overview
This PR aims to improve responsiveness of the custom LSP request $/getKnownContexts by avoiding a blocking wait on analysis state before computing known contexts.
Changes:
- Removed an
ctx.wait_for_state(AnalysisProgressKind::Isolated, AnalysisWaitKind::Existence, ...)call fromGetKnownContextsRequest::handle, so the request returns immediately.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JonatanWaern
force-pushed
the
reduce-workpool-usage
branch
from
June 15, 2026 11:20
cbb33af to
d4fc3b3
Compare
TSonono
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.