[UR][L0v2] Introduce static linking option#21845
Open
kswiecicki wants to merge 16 commits into
Open
Conversation
kswiecicki
force-pushed
the
ur-static-linking
branch
from
May 22, 2026 09:01
98b9b33 to
44a899a
Compare
kswiecicki
force-pushed
the
ur-static-linking
branch
2 times, most recently
from
June 25, 2026 22:47
b06fe31 to
3010238
Compare
kswiecicki
force-pushed
the
ur-static-linking
branch
2 times, most recently
from
July 7, 2026 14:45
f15f4d4 to
18e945c
Compare
kswiecicki
force-pushed
the
ur-static-linking
branch
10 times, most recently
from
July 23, 2026 19:32
cc610cd to
6f1d017
Compare
kswiecicki
force-pushed
the
ur-static-linking
branch
2 times, most recently
from
July 24, 2026 07:05
23baa21 to
54c2ca6
Compare
kswiecicki
force-pushed
the
ur-static-linking
branch
from
July 24, 2026 07:41
54c2ca6 to
1fcff72
Compare
bratpiorka
approved these changes
Jul 24, 2026
bratpiorka
left a comment
bratpiorka
left a comment
Contributor
There was a problem hiding this comment.
CUDA/HIP/OpenCL/native CPU LGTM
mateuszpn
reviewed
Jul 24, 2026
| hPlatform->Contexts.push_back(v2_cast(*phContext)); | ||
| } | ||
| return UR_RESULT_SUCCESS; | ||
| } catch (...) { |
Contributor
There was a problem hiding this comment.
If I understand things right, previous delete *phContext is missing and the pointer won't be deleted when exception is thrown after it is assigned? Probability is minor, though
Same in line 298.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.