[SYCL][NewOffloadModel] Set image compile/link options for non-SPIR targets#22748
Open
sarnex wants to merge 1 commit into
Open
[SYCL][NewOffloadModel] Set image compile/link options for non-SPIR targets#22748sarnex wants to merge 1 commit into
sarnex wants to merge 1 commit into
Conversation
…argets Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
mdtoguchi
approved these changes
Jul 25, 2026
mdtoguchi
left a comment
mdtoguchi
left a comment
Contributor
There was a problem hiding this comment.
In regards to matching with what we did for the old-model, this makes sense. As you stated, it's not clear what the actual intentional behavior is. I would consider this as a side impact from initial early spir64 implementation and when enabling for 3rd party support, the behavior just took a ride with what was there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is pretty weird.
We have a test that makes sure if we compile with
-gthat we pass-gat runtime to UR.The weird part is that they expect this for NVPTX, as well as SPIR.
In the old offload model we propagate
-gto the image flags even for NVPTX, so do the same for the new offload model.It is not totally clear if:
The code that adds this for the old offload model is here, you can see the triple check at the link but the flag is actually added in
AddSPIRVImpliedTargetArgsThe change is low impact and trivial so IMO let's just match support for the old offload model and move on.