[SYCL] Fix g++ host-compiler build after 31945d82be43 - #22849
Merged
againull merged 1 commit intoAug 2, 2026
Conversation
Fix sycl-in-tree::Complex~sycl_complex_include_order.cpp and sycl-in-tree::Regression~fsycl-host-compiler.cpp tests that broke after commit 31945d8 which deprecated the sampler class and access targets. The commit used __SYCL_DEPRECATED which unconditionally expands to [[deprecated(...)]] on all compilers. When compiled with g++ (via -fsycl-host-compiler=g++) versions prior to GCC 13, mixing __attribute__((visibility("default"))) with [[deprecated(...)]] on a class declaration causes a parse error. Use __SYCL2020_DEPRECATED instead, which is gated on SYCL_LANGUAGE_VERSION == 202012L and matches the pattern used by other SYCL 2020 deprecations in the same files. Fixes: CMPLRLLVM-77354 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
againull
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix sycl-in-tree::Complex
sycl_complex_include_order.cpp and sycl-in-tree::Regressionfsycl-host-compiler.cpp tests that broke after commit 31945d8 which deprecated the sampler class and access targets.The commit used __SYCL_DEPRECATED which unconditionally expands to [[deprecated(...)]] on all compilers. When compiled with g++ (via -fsycl-host-compiler=g++) versions prior to GCC 13, mixing attribute((visibility("default"))) with [[deprecated(...)]] on a class declaration causes a parse error. Use __SYCL2020_DEPRECATED instead, which is gated on SYCL_LANGUAGE_VERSION == 202012L and matches the pattern used by other SYCL 2020 deprecations in the same files.
Fixes: CMPLRLLVM-77354