feat(i18n): pull latest translations from openlibrary-i18n in olbase#13070
Draft
mekarpeles wants to merge 1 commit into
Draft
feat(i18n): pull latest translations from openlibrary-i18n in olbase#13070mekarpeles wants to merge 1 commit into
mekarpeles wants to merge 1 commit into
Conversation
Adds a git clone step to Dockerfile.olbase that fetches the current messages.po for each language from internetarchive/openlibrary-i18n at image build time. olbase rebuilds weekly (and on workflow_dispatch), so translations stay current without any changes to this repo. Local dev: volume-mount via OL_MOUNT_DIR still serves the .po files committed in this repo. Removing those files (so local dev also pulls from openlibrary-i18n) is a separate future phase.
Member
Author
|
Summary: When: a PR is merged to openlibrary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
git clonestep toDockerfile.olbasethat fetches the currentmessages.pofor all languages frominternetarchive/openlibrary-i18nat image build time. olbase rebuilds weekly (Tuesdays) and onworkflow_dispatch, so translations stay fresh without any changes to this repo.How it fits into the pipeline
Local dev
Volume-mount via
OL_MOUNT_DIRstill serves the.pofiles committed in this repo — the baked-in translations are only used in production images. Removing the committed.pofiles (so local dev also pulls fromopenlibrary-i18n) is a separate future phase and requires amake i18n-syncor similar mechanism first.Files changed
docker/Dockerfile.olbase— oneRUN git cloneblock afterCOPY . /openlibraryDependencies
internetarchive/openlibrary-i18nmust exist and have translations onmain(already true — PRs catalog/onix/onix.py attempts to use a global variable in init(), but doesn't declare it global #2–Adds BeautifulSoup as dependency during install #4 merged)Related