fix: resolve download record bar overflowing containers globally#13091
Conversation
|
Thanks @RsbhThakur for the PR! The linked issue hasn't been triaged yet — triage happens on Mondays and Fridays. There are currently 108 open non-draft PRs ahead of yours. PR triage checklist (maintainers / Richy)
Note This comment was automatically generated by PAM, Open Library's Project AI Manager. PAM provides status visibility, performs basic project management functions, and gives actionable feedback so contributors aren't left waiting. |
mekarpeles
left a comment
There was a problem hiding this comment.
Thank you! If possible, we like to avoid inline styles
|
Alright! Will update the pr soon. Thanks for your input! |
5082504 to
96dc6ef
Compare
|
Pushed an update addressing the review feedback. Further inputs and suggestions are welcome! |
There was a problem hiding this comment.
This bottom row currently uses float: right to get the content right aligned. This approach has been superseded by modern CSS which lets us use flex or grid.
In this case, let's use display flex. Additionally, let's use our spacing CSS variables. spacing.css
Take a peek at the CSS edits in the dev tools here:
96dc6ef to
eef9ad8
Compare
|
Thanks for your suggestion @lokesh! I have updated the PR based on your suggestion. Also for note i have also added Here is the screenshot:
Let me know if you have any more suggestions or if it looks good to you! |
lokesh
left a comment
There was a problem hiding this comment.
Thanks for iterating on the edits! We ended up at a better place
|
Hi @mekarpeles, since @lokesh has approved the latest changes, could you please take a look or clear/dismiss your original review block when you have a moment so that the PR can be merged? Thank you! |
Requested changes related to inline styles have been addressed. I've verified all of the changes in the PR manually. LGTM

Closes #13090
fix
Technical
clearfixcontainer (<div class="clearfix"></div>) inside the sharedopenlibrary/templates/lib/exports.htmltemplate.margin-bottom: calc(-1 * var(--contentBody-padding));) inline to pull the downloads bar up and align it cleanly against the container's bottom edge (negating the default#contentBodybottom padding)..pageHistory__tools) globally for all views utilizing the exports template (Edition view, Work view, and Author view) without duplicating layout fixes across multiple templates.Testing
http://localhost:8080/books/OL24620876M/Responsive_Web_Design(or any other book detail page).Screenshot