Skip to content

fix: resolve download record bar overflowing containers globally#13091

Merged
lokesh merged 1 commit into
internetarchive:masterfrom
RsbhThakur:13090/fix/download-record-bar-overflow
Jul 17, 2026
Merged

fix: resolve download record bar overflowing containers globally#13091
lokesh merged 1 commit into
internetarchive:masterfrom
RsbhThakur:13090/fix/download-record-bar-overflow

Conversation

@RsbhThakur

Copy link
Copy Markdown
Contributor

Closes #13090

fix

Technical

  • Added a structural clearfix container (<div class="clearfix"></div>) inside the shared openlibrary/templates/lib/exports.html template.
  • Applied the negative margin calculation (margin-bottom: calc(-1 * var(--contentBody-padding));) inline to pull the downloads bar up and align it cleanly against the container's bottom edge (negating the default #contentBody bottom padding).
  • This resolves the uncontained float (.pageHistory__tools) globally for all views utilizing the exports template (Edition view, Work view, and Author view) without duplicating layout fixes across multiple templates.

Testing

  1. Visit the local book detail page: http://localhost:8080/books/OL24620876M/Responsive_Web_Design (or any other book detail page).
  2. Verify that the "Download catalog record" bar at the bottom is fully contained inside the white container and aligns perfectly with the bottom border.

Screenshot

image

@openlibrary-bot

Copy link
Copy Markdown
Collaborator

Thanks @RsbhThakur for the PR!

The linked issue hasn't been triaged yet — triage happens on Mondays and Fridays. There are currently 108 open non-draft PRs ahead of yours.

PR triage checklist (maintainers / Richy)
  • PR description — not empty; explains what the change does and how to verify it
  • References an issue — PR body contains a #NNN reference
    • Linked issue is triaged — has a Priority: * label (not just Needs: Triage)
    • Linked issue is assigned — has at least one assignee
  • Commit history clean — no WIP/fixup/conflict noise; commit messages are meaningful
  • CI passing — no failing check-runs
  • Test cases present — if the change touches substantive logic, test coverage exists or is explained
  • Proof of testing — PR body includes a description of what was tested, a screenshot, or a video

Note

This comment was automatically generated by PAM, Open Library's Project AI Manager. PAM provides status visibility, performs basic project management functions, and gives actionable feedback so contributors aren't left waiting.

@mekarpeles mekarpeles left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! If possible, we like to avoid inline styles

@mekarpeles mekarpeles removed the Needs: Response Issues which require feedback from lead label Jul 4, 2026
@RsbhThakur

RsbhThakur commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

Alright! Will update the pr soon. Thanks for your input!

@github-actions github-actions Bot added the Needs: Response Issues which require feedback from lead label Jul 4, 2026
@RsbhThakur
RsbhThakur force-pushed the 13090/fix/download-record-bar-overflow branch from 5082504 to 96dc6ef Compare July 5, 2026 13:37
@RsbhThakur

Copy link
Copy Markdown
Contributor Author

Pushed an update addressing the review feedback. Further inputs and suggestions are welcome!

@lokesh lokesh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bottom row currently uses float: right to get the content right aligned. This approach has been superseded by modern CSS which lets us use flex or grid.

In this case, let's use display flex. Additionally, let's use our spacing CSS variables. spacing.css

Take a peek at the CSS edits in the dev tools here:

Image

@RsbhThakur
RsbhThakur force-pushed the 13090/fix/download-record-bar-overflow branch from 96dc6ef to eef9ad8 Compare July 7, 2026 20:44
@RsbhThakur

Copy link
Copy Markdown
Contributor Author

Thanks for your suggestion @lokesh! I have updated the PR based on your suggestion.

Also for note i have also added margin-bottom: calc(-1 * var(--spacing-sm)); in .pageHistory__tools to equate the vertical padding for the text.

Here is the screenshot:

image

Let me know if you have any more suggestions or if it looks good to you!

@RsbhThakur
RsbhThakur requested a review from lokesh July 7, 2026 20:54

@lokesh lokesh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating on the edits! We ended up at a better place

@RsbhThakur

RsbhThakur commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

Hi @mekarpeles, since @lokesh has approved the latest changes, could you please take a look or clear/dismiss your original review block when you have a moment so that the PR can be merged? Thank you!

@lokesh
lokesh dismissed mekarpeles’s stale review July 17, 2026 13:56

Requested changes related to inline styles have been addressed. I've verified all of the changes in the PR manually. LGTM

@lokesh
lokesh merged commit dcf1e75 into internetarchive:master Jul 17, 2026
4 checks passed
@RsbhThakur
RsbhThakur deleted the 13090/fix/download-record-bar-overflow branch July 17, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Response Issues which require feedback from lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix uncontained CSS float on book page causing catalog download tools to overflow content boundaries

4 participants