Skip to content

Replace dev feature flag with LOCAL_DEV#13123

Open
Sanket17052006 wants to merge 1 commit into
internetarchive:masterfrom
Sanket17052006:replace-dev-flag
Open

Replace dev feature flag with LOCAL_DEV#13123
Sanket17052006 wants to merge 1 commit into
internetarchive:masterfrom
Sanket17052006:replace-dev-flag

Conversation

@Sanket17052006

Copy link
Copy Markdown
Contributor

Part of #12946

This PR replaces the legacy "dev" in ctx.features / "dev" in config.features checks with get_ol_env().LOCAL_DEV, as it's an environment indicator (only enabled locally,not in testing/production).

Technical

  • Removed dev: enabled from conf/openlibrary.yml
  • Replaced all "dev" in ... features checks with get_ol_env().LOCAL_DEV.
  • Added get_ol_env to web.template.Template.globals for template access
  • Removed stale # dev: bool comment from the pydantic Features model.
  • Unused import infogami removed from admin.py and deprecated_handler.py

Testing

No behavioral change: LOCAL_DEV is never set in production, same as old dev flag

Screenshot

N/A

Stakeholders

@RayBB

@openlibrary-bot

Copy link
Copy Markdown
Collaborator

Thanks for the PR, @Sanket17052006!

A reviewer must first be assigned. There are currently 13 open PRs of equal or higher priority ahead of yours.

PR triage checklist (maintainers / Richy)
  • PR description — not empty; explains what the change does and how to verify it
  • References an issue — PR body contains a #NNN reference
    • Linked issue is triaged — has a Priority: * label (not just Needs: Triage)
    • Linked issue is assigned — has at least one assignee
  • Commit history clean — no WIP/fixup/conflict noise; commit messages are meaningful
  • CI passing — no failing check-runs
  • Test cases present — if the change touches substantive logic, test coverage exists or is explained
  • Proof of testing — PR body includes a description of what was tested, a screenshot, or a video

Note

This comment was automatically generated by PAM, Open Library's Project AI Manager. PAM provides status visibility, performs basic project management functions, and gives actionable feedback so contributors aren't left waiting.

— Richy, via PAM (Open Library's Project AI Manager)

@github-project-automation github-project-automation Bot moved this to Waiting Review/Merge from Staff in Ray's Project Jul 6, 2026
@mekarpeles

Copy link
Copy Markdown
Member

This needs to be evaluated by staff and also tested on testing + prod server.

@mekarpeles mekarpeles added the Needs: Special Deploy This PR will need a non-standard deploy to production label Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Special Deploy This PR will need a non-standard deploy to production

Projects

Status: Waiting Review/Merge from Staff

Development

Successfully merging this pull request may close these issues.

4 participants