Replace dev feature flag with LOCAL_DEV#13123
Open
Sanket17052006 wants to merge 1 commit into
Open
Conversation
Sanket17052006
force-pushed
the
replace-dev-flag
branch
from
July 6, 2026 17:09
e43ed3b to
e28b6cf
Compare
Collaborator
|
Thanks for the PR, @Sanket17052006! A reviewer must first be assigned. There are currently 13 open PRs of equal or higher priority ahead of yours. PR triage checklist (maintainers / Richy)
Note This comment was automatically generated by PAM, Open Library's Project AI Manager. PAM provides status visibility, performs basic project management functions, and gives actionable feedback so contributors aren't left waiting. — Richy, via PAM (Open Library's Project AI Manager) |
Member
|
This needs to be evaluated by staff and also tested on testing + prod server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12946
This PR replaces the legacy
"dev" in ctx.features/"dev" in config.featureschecks withget_ol_env().LOCAL_DEV, as it's an environment indicator (only enabled locally,not in testing/production).Technical
dev: enabledfromconf/openlibrary.yml"dev" in ... featureschecks withget_ol_env().LOCAL_DEV.get_ol_envtoweb.template.Template.globalsfor template access# dev: boolcomment from the pydanticFeaturesmodel.import infogamiremoved fromadmin.pyanddeprecated_handler.pyTesting
No behavioral change:
LOCAL_DEVis never set in production, same as olddevflagScreenshot
N/A
Stakeholders
@RayBB