Don't save empty identifiers#13149
Open
hornc wants to merge 2 commits into
Open
Conversation
hornc
force-pushed
the
fix_emptyidentifiers
branch
from
July 13, 2026 06:00
89560c9 to
fb89fa0
Compare
hornc
force-pushed
the
fix_emptyidentifiers
branch
from
July 13, 2026 08:57
93159cb to
e220d8b
Compare
hornc
force-pushed
the
fix_emptyidentifiers
branch
from
July 13, 2026 10:16
b129979 to
315866a
Compare
hornc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1946
Technical
Testing
Tested locally saving various no-op changes, before this change
identifiers: {}was saved on http://localhost:8080/books/OL23269118M/Alice's_adventures_in_WonderlandAfter this change, empty
identifiersare not created, and any existing empty{}dicts are cleared.Screenshot
Stakeholders