Skip to content

[probe] Validate extents time start before time end #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RustedBones wants to merge 1 commit into
base: main
Choose a base branch
from
+37 −0
Draft

[probe] Validate extents time start before time end #1367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions monitoring/prober/scd/test_constraint_simple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,19 @@ def test_create_constraint_missing_time_end(ids, scd_api, scd_session):
assert resp.status_code == 400, resp.content


@for_api_versions(scd.API_0_3_17)
@default_scope(SCOPE_CM)
@depends_on(test_ensure_clean_workspace)
def test_create_constraint_time_start_after_time_end(ids, scd_api, scd_session):
req = _make_c1_request()
e = req["extents"][0]
t = e["time_end"]
e["time_end"] = e["time_start"]
e["time_start"] = t
resp = scd_session.put(f"/constraint_references/{ids(CONSTRAINT_TYPE)}", json=req)
assert resp.status_code == 400, resp.content


@for_api_versions(scd.API_0_3_17)
@depends_on(test_ensure_clean_workspace)
def test_create_constraint(ids, scd_api, scd_session):
Expand Down
12 changes: 12 additions & 0 deletions monitoring/prober/scd/test_operation_simple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,18 @@ def test_create_op_missing_time_end(ids, scd_api, scd_session):
assert resp.status_code == 400, resp.content


@default_scope(SCOPE_SC)
@depends_on(test_ensure_clean_workspace)
def test_create_op_time_start_after_time_end(ids, scd_api, scd_session):
req = _make_op1_request()
e = req["extents"][0]
time_end = e["time_end"]
e["time_end"] = e["time_start"]
e["time_start"] = time_end
resp = scd_session.put(f"/operational_intent_references/{ids(OP_TYPE)}", json=req)
assert resp.status_code == 400, resp.content


@depends_on(test_ensure_clean_workspace)
def test_create_op(ids, scd_api, scd_session, scd_session_cp, scd_session_cm):
req = _make_op1_request()
Expand Down
12 changes: 12 additions & 0 deletions monitoring/prober/scd/test_subscription_simple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,18 @@ def test_sub_does_not_exist_query(ids, scd_api, scd_session):
]


@for_api_versions(scd.API_0_3_17)
@default_scope(SCOPE_SC)
def test_create_sub_time_start_after_time_end(ids, scd_api, scd_session):
req = _make_sub1_req(scd_api)
e = req["extents"]
time_end = e["time_end"]
e["time_end"] = e["time_start"]
e["time_start"] = time_end
resp = scd_session.put(f"/subscriptions/{ids(SUB_TYPE)}", json=req)
assert resp.status_code == 400, resp.content


@for_api_versions(scd.API_0_3_17)
@default_scope(SCOPE_SC)
def test_create_sub(ids, scd_api, scd_session):
Expand Down
Loading