[uss_qualifier/astm/utm] Detect op intent details outside reference#1389
Merged
BenjaminPelletier merged 3 commits intointeruss:mainfrom Mar 11, 2026
Merged
Conversation
mickmis
approved these changes
Mar 11, 2026
Contributor
mickmis
left a comment
mickmis
left a comment
There was a problem hiding this comment.
LGTM, just some suggestions
|
|
||
| ## 🛑 Details 4D extents are within reference extents check | ||
|
|
||
| If the 4D extents (start time, end time, and altitude if specified) of any of the detailed operational intent volumes are not fully contained within the 4D extents of the operational intent reference, this check will fail per **[astm.f3548.v21.USS0105,1](../../../requirements/astm/f3548/v21.md)**. |
Contributor
There was a problem hiding this comment.
Suggested change
| If the 4D extents (start time, end time, and altitude if specified) of any of the detailed operational intent volumes are not fully contained within the 4D extents of the operational intent reference, this check will fail per **[astm.f3548.v21.USS0105,1](../../../requirements/astm/f3548/v21.md)**. | |
| If the 4D extents (start time, end time, and altitude if specified) of any of the operational intent details volumes are not fully contained within the 4D extents of the reference, this check will fail per **[astm.f3548.v21.USS0105,1](../../../requirements/astm/f3548/v21.md)**. |
|
|
||
| If the operational intent details reported by the USS do not match the user's flight intent, this check will fail per **[interuss.automated_testing.flight_planning.ExpectedBehavior](../../../requirements/interuss/automated_testing/flight_planning.md)** and **[astm.f3548.v21.OPIN0025](../../../requirements/astm/f3548/v21.md)**. | ||
|
|
||
| ## 🛑 Details 4D extents are within reference extents check |
Contributor
There was a problem hiding this comment.
Suggested change
| ## 🛑 Details 4D extents are within reference extents check | |
| ## 🛑 Operational intent details extents are contained within reference extents check |
| all_volumes = oi_full.details.get("volumes", []) + oi_full.details.get( | ||
| "off_nominal_volumes", [] | ||
| ) | ||
| for v in all_volumes: |
Contributor
There was a problem hiding this comment.
It could make sense using Volume4DCollection instead.
Member
Author
There was a problem hiding this comment.
Ah, yeah, that's probably the better approach -- will change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hopefully resolves #1377 by checking whether op intent detailed volumes exceed the bounds of the reference whenever a shared op intent is validated.
Note: this PR was generated primarily by an AI agent.