Skip to content

feat(caddy): support prerelease manifest redirects - #1

Open
jumoog wants to merge 3 commits into
mainfrom
capy/featcaddy-support-prerelease-man
Open

feat(caddy): support prerelease manifest redirects#1
jumoog wants to merge 3 commits into
mainfrom
capy/featcaddy-support-prerelease-man

Conversation

@jumoog

@jumoog jumoog commented Jul 17, 2026

Copy link
Copy Markdown
Member

Adds manifest-prerelease.json to the Caddy redirect flow so Jellyfin clients are sent to the matching versioned prerelease manifest on jsDelivr while non-manifest paths and non-Jellyfin user agents still fall back to GitHub.

  • Reuses the existing Jellyfin version capture for both manifest.json and manifest-prerelease.json, preserving the current CDN commit pinning behavior.
  • Updates redirect tests to cover Jellyfin 12.x only, including the prerelease manifest path and non-Jellyfin fallback for both manifest files.

Open INTRO-103 INTRO-103

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@jumoog jumoog added the capy Generated by capy.ai label Jul 17, 2026 — with Capy AI
Comment thread .github/workflows/test-caddy.yml Outdated
run_test "$HOST" "Jellyfin-Server/10.11.0" "/manifest.json" "cdn:10.11" "10.11 → branch"
run_test "$HOST" "Jellyfin-Server/12.0.0" "/manifest.json" "cdn:12.0" "12.0 → branch"
run_test "$HOST" "Jellyfin-Server/10.9.2" "/" "literal:https://github.com/intro-skipper/" "Not /manifest.json → GitHub"
run_test "$HOST" "Jellyfin-Server/12.0.0" "/manifest.json" "cdn:12.0:manifest.json" "12.0 → branch"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: 10.x routing is no longer covered by tests

This PR removes all 10.x redirect test cases (previously 10.8, 10.9, 10.10, 10.11), but docker/Caddyfile:35 still advertises and routes 10.x via the VER header regex (10\.\d+|12\.\d+). If 10.x routing regresses, CI will no longer catch it. Consider keeping at least one 10.x manifest case (e.g. cdn:10.11:manifest.json) so the live 10.x support stays verified.


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

@kilo-code-bot

kilo-code-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • .github/workflows/test-caddy.yml - 0 issues
Previous Review Summaries (2 snapshots, latest commit 044b084)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 044b084)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
.github/workflows/test-caddy.yml 99 10.x redirect coverage dropped while Caddyfile still routes 10.x
Files Reviewed (2 files)
  • docker/Caddyfile - 0 issues (prerelease manifest regex routing correct)
  • .github/workflows/test-caddy.yml - 1 issue (10.x coverage regression)

Fix these issues in Kilo Cloud

Previous review (commit 5c39d91)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
.github/workflows/test-caddy.yml 99 10.x redirect coverage dropped while Caddyfile still routes 10.x
Files Reviewed (2 files)
  • docker/Caddyfile - 0 issues (regex/manifest routing correct)
  • .github/workflows/test-caddy.yml - 1 issue (coverage regression)

Fix these issues in Kilo Cloud


Reviewed by step-3.7-flash · Input: 76.2K · Output: 2.5K · Cached: 170.5K

jumoog and others added 2 commits July 17, 2026 18:34
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

capy Generated by capy.ai

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants