Repository navigation
Conversation
redxzeta
requested review from
WinterQuant,
johnintuit,
murari316 and
sandeep-mewara
as code owners
October 4, 2026 04:44
Author
|
Investigated CI run 37177863735 on head An upstream maintainer must approve the run; the authenticated contributor account has read-only upstream permissions. No source or workflow change, check suppression, or rerun was performed. The focused local validation remains as recorded above; required review and successful final-head hosted CI remain pending. T3 watching remains enabled. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strict
cargo clippy --all-targets --all-features -- -D warningsfails on clean upstreamcf82f5dwith current stable Rust: constant-sizechunks_exact, redundant references to cached Postgres handles, and temporary vectors used only as slices.Use array chunks for float decoding, pass cached handles directly, and use arrays in the two remote-document test fixtures. These focused edits preserve behavior and remove the causes without suppressing lints, changing checks, or altering feature defaults. Separate prerequisite for diagnostics PR #81.
Validation:
cargo fmt --all -- --check,git diff --check, and strict all-target/all-feature Clippy pass. Remote features are compile-checked; no provider services are started or configured. Full runtime validation is recorded on PR #81 after integrating the independent embedding-bounds fix (#82).Hosted CI run 37177863735 for head
9e68b72reportsaction_required. The run page explicitly says it awaits maintainer approval; the API reports zero jobs, with no hosted validation result. The authenticated contributor account has read-only upstream permissions and cannot approve the run. Required PR review and successful hosted CI remain pending.