Skip to content

ui: remove incorrect generic pluralization#329

Merged
slint merged 1 commit intoinveniosoftware:masterfrom
ulbmuenster:fix_hacky_pluralization
Apr 7, 2026
Merged

ui: remove incorrect generic pluralization#329
slint merged 1 commit intoinveniosoftware:masterfrom
ulbmuenster:fix_hacky_pluralization

Conversation

@SarahW91
Copy link
Copy Markdown
Contributor

@SarahW91 SarahW91 commented Apr 2, 2026

Description

Generic pluralization with an "s" is wrong in most languages except English. I suggest instead adding a general "Error(s)" and "Recommendation(s)" here and removing the incorrect pluralization in this module.

For a similar discussion see also this PR.

In this case, I personally think just adding the count in brackets looks off:

image

vs.

image

What do you think?

Checklist

@SarahW91 SarahW91 requested review from slint, tmorrell and zzacharo April 2, 2026 09:13
Copy link
Copy Markdown
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that in this case, this looks better. I vaguely remember a discussion at some point that the (s) doesn't have an equivalent in some languages... Also from reading https://cldr.unicode.org/index/cldr-spec/plural-rules it looks like we'll have some troubles.

I think it's definitely an improvement though to what we currently have, which is just plain wrong in translations :)

@SarahW91
Copy link
Copy Markdown
Contributor Author

SarahW91 commented Apr 2, 2026

I agree that this is definitely not the most elegant solution ;) But it seems to be as good as it gets without putting in way more effort

@SarahW91
Copy link
Copy Markdown
Contributor Author

SarahW91 commented Apr 2, 2026

Generic plural can be added with inveniosoftware/invenio-app-rdm#3400

Copy link
Copy Markdown

@tmorrell tmorrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SarahW91
Copy link
Copy Markdown
Contributor Author

SarahW91 commented Apr 7, 2026

Great, so who could merge these?

@tmorrell
Copy link
Copy Markdown

tmorrell commented Apr 7, 2026

It's not so much who, as whether it's been up long enough for folks to express concerns. I'll see if we can get another approval on inveniosoftware/invenio-app-rdm#3400

@slint slint merged commit 30b2ba4 into inveniosoftware:master Apr 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants