ui: remove incorrect generic pluralization#329
Conversation
slint
left a comment
There was a problem hiding this comment.
Agree that in this case, this looks better. I vaguely remember a discussion at some point that the (s) doesn't have an equivalent in some languages... Also from reading https://cldr.unicode.org/index/cldr-spec/plural-rules it looks like we'll have some troubles.
I think it's definitely an improvement though to what we currently have, which is just plain wrong in translations :)
|
I agree that this is definitely not the most elegant solution ;) But it seems to be as good as it gets without putting in way more effort |
|
Generic plural can be added with inveniosoftware/invenio-app-rdm#3400 |
There was a problem hiding this comment.
Works for me if combined with https://github.com/inveniosoftware/invenio-app-rdm/pull/3400/changes
|
Great, so who could merge these? |
|
It's not so much who, as whether it's been up long enough for folks to express concerns. I'll see if we can get another approval on inveniosoftware/invenio-app-rdm#3400 |
Description
Generic pluralization with an "s" is wrong in most languages except English. I suggest instead adding a general "Error(s)" and "Recommendation(s)" here and removing the incorrect pluralization in this module.
For a similar discussion see also this PR.
In this case, I personally think just adding the count in brackets looks off:
vs.
What do you think?
Checklist