feat: Add way to test new action sheet feature#776
Open
OS-pedrogustavobilro wants to merge 7 commits intomainfrom
Open
feat: Add way to test new action sheet feature#776OS-pedrogustavobilro wants to merge 7 commits intomainfrom
OS-pedrogustavobilro wants to merge 7 commits intomainfrom
Conversation
jcesarmobile
reviewed
Mar 6, 2026
Member
jcesarmobile
left a comment
jcesarmobile
left a comment
There was a problem hiding this comment.
while it's not related to the action-sheet change, since you are updating to capacitor 8.1.0, can you update to 8.2.0 instead?
We may look into introducing cancelable for iOS, so this helps test it better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates action-sheet and pwa-elements, while also adding a way to properly test the new action-sheet feature (ionic-team/capacitor-plugins#2285)
Also includes some formatting fixes in a couple of ts files, because lint was failing.