Skip to content

upstream(core): Run consensus startup async#11928

Merged
jkrvivian merged 1 commit into
core-protocol/upstream-changes/mainnet-1.51.5-1.52.3from
core-protocol/upstream-1.51.5-1.52.3/2d263
Jun 22, 2026
Merged

upstream(core): Run consensus startup async#11928
jkrvivian merged 1 commit into
core-protocol/upstream-changes/mainnet-1.51.5-1.52.3from
core-protocol/upstream-1.51.5-1.52.3/2d263

Conversation

@jkrvivian

@jkrvivian jkrvivian commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Description of change

Spawns consensus startup asynchronously so it no longer blocks the other
node components during validator bring-up. The consensus handler is now
created before the authority starts (so it is listening for committed
sub-dags first), and the replay-waiting mechanism is rewired from holding
an Arc<ConsensusAuthority> to receiving the CommitConsumerMonitor over
a broadcast channel. A DISABLE_REPLAY_WAITER env var is added as an
escape hatch.

Built on top of #11850 which is required to prevent OOM on recovery.

Links to any relevant issues

Part of #11885

How the change has been tested

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@jkrvivian jkrvivian added the node Issues related to the Core Node team label Jun 16, 2026
@jkrvivian jkrvivian self-assigned this Jun 16, 2026
@jkrvivian jkrvivian force-pushed the core-protocol/upstream-changes/mainnet-1.51.5-1.52.3 branch from 00a4edd to 3937272 Compare June 17, 2026 12:10
@jkrvivian jkrvivian force-pushed the core-protocol/upstream-1.51.5-1.52.3/2d263 branch from 2f52a63 to bb0d493 Compare June 17, 2026 12:11
@jkrvivian jkrvivian force-pushed the core-protocol/upstream-changes/mainnet-1.51.5-1.52.3 branch from 3937272 to 3bbfda7 Compare June 17, 2026 12:30
@jkrvivian jkrvivian force-pushed the core-protocol/upstream-1.51.5-1.52.3/2d263 branch from bb0d493 to c66b93b Compare June 17, 2026 12:31
@jkrvivian jkrvivian marked this pull request as ready for review June 17, 2026 12:46
@jkrvivian jkrvivian requested review from a team as code owners June 17, 2026 12:46
@jkrvivian jkrvivian force-pushed the core-protocol/upstream-changes/mainnet-1.51.5-1.52.3 branch from 3bbfda7 to 9a09587 Compare June 18, 2026 05:46
@jkrvivian jkrvivian requested a review from a team as a code owner June 18, 2026 05:46
@jkrvivian jkrvivian force-pushed the core-protocol/upstream-1.51.5-1.52.3/2d263 branch from c66b93b to 299993b Compare June 18, 2026 05:46
@jkrvivian jkrvivian merged commit 1f8f43e into core-protocol/upstream-changes/mainnet-1.51.5-1.52.3 Jun 22, 2026
38 checks passed
@jkrvivian jkrvivian deleted the core-protocol/upstream-1.51.5-1.52.3/2d263 branch June 22, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-protocol node Issues related to the Core Node team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants