Skip to content

Chart: move crds chart logic after setting image#270

Merged
defo89 merged 1 commit intomainfrom
chart-fix-crds-chart
Feb 11, 2026
Merged

Chart: move crds chart logic after setting image#270
defo89 merged 1 commit intomainfrom
chart-fix-crds-chart

Conversation

@defo89
Copy link
Contributor

@defo89 defo89 commented Feb 11, 2026

Proposed Changes

  • This makes sure that crds chart also has the updated image values

Summary by CodeRabbit

  • Chores
    • Updated Helm chart packaging workflow to generate multiple chart variants—one with CRDs included in the template and another with CRDs removed from the template.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

Walkthrough

The CI workflow .github/workflows/publish-chart.yml is modified to reorder and duplicate Helm chart packaging steps. The previously removed "Package Helm chart with crds folder in template" step is reintroduced after the image tagging step, followed by a new "Package Helm chart with removed crds folder from template folder" step, resulting in multiple sequential packaging executions with different CRD configurations.

Changes

Cohort / File(s) Summary
CI/CD Workflow Configuration
.github/workflows/publish-chart.yml
Reordered and duplicated Helm chart packaging steps with CRD-specific variants. Introduces multiple packaging executions with and without CRD folder configurations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

size/S

Suggested reviewers

  • hardikdr
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description provides context for the change but is incomplete compared to the template structure. Consider expanding the description to include additional bullet points and link any related issues using 'Fixes #' format if applicable.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: reordering the crds chart logic to run after image setting.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chart-fix-crds-chart

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@defo89 defo89 merged commit 3f3a66a into main Feb 11, 2026
17 checks passed
@defo89 defo89 deleted the chart-fix-crds-chart branch February 11, 2026 08:58
@github-project-automation github-project-automation bot moved this from Backlog to Done in Metal Automation Feb 11, 2026
@github-project-automation github-project-automation bot moved this to Done in Roadmap Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants