pycuampcor deramp improvement #194
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) fix the pixelIdx error (thanks to @bhawkins) 2) use double precision for phase correction 3) add derampAxis parameter for options to deramp along certain direction 4) move cuDeramp from oversampler to chunk processor; making the code more readable
Contributor
xhuang-jpl
requested review from
bhawkins,
hfattahi,
oberonia78,
seongsujeong and
xhuang-jpl
xhuang-jpl
approved these changes
Dec 17, 2025
Contributor
xhuang-jpl
left a comment
xhuang-jpl
left a comment
There was a problem hiding this comment.
I have tested this PR on both CPU and GPU, which show significant improvements of the correlation surface peak after the ramp phase estimation bug fix. Thanks again @lijun99 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the deramp procedure in pycuampcor/dense_offset to address the issue of (linear) phase ramp along azimuth due to the Doppler Centroids.