Conversation
|
😊 Welcome @shamsher31! This is either your first contribution to the Istio pkg repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
Skipping CI for Draft Pull Request. |
howardjohn
left a comment
There was a problem hiding this comment.
IMO "vendor version" should not be a concept. For example:
"serverVersion": {
"major": "1",
"minor": "20+",
"gitVersion": "v1.20.6-gke.1400",
"gitCommit": "b7ccf3218bdb80cd2d66ed6186d78f18f1ef03c6",
"gitTreeState": "clean",
"buildDate": "2021-05-05T09:19:45Z",
"goVersion": "go1.15.10b5",
"compiler": "gc",
"platform": "linux/amd64"
}
GKE k8s version. The "vendor" aspect is just in the normal version
|
@shamsher31 in the build if VERSION is set it is used to link stamp binaries. We will now set that VERsIOn to the full version including Google specific extensions. Like 1.10.2-asm.5 |
|
@shamsher31: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
To fix istio/istio#33421