Skip to content

Conversation

@grnmeira
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@grnmeira grnmeira requested a review from a team as a code owner January 27, 2026 13:08
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 27, 2026
@keithmattix
Copy link
Contributor

/retest

@keithmattix
Copy link
Contributor

/retest

"cloud.region=test-region," +
"cloud.availability_zone=test-zone",
},
ResponseHeaders: map[string]string{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean? Are these expected response headers? How does the http call have request and response headers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's confusing. The request headers is what we send from downstream to Envoy. The response headers is what we check against in the response coming from Envoy.

@istio-testing istio-testing merged commit f13c2fe into istio:experimental-ambient-multicluster-telemetry Jan 29, 2026
7 checks passed
@keithmattix keithmattix added the cherrypick/release-1.29 Set this label on a PR to auto-merge it to the release-1.29 branch label Jan 29, 2026
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #6803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherrypick/release-1.29 Set this label on a PR to auto-merge it to the release-1.29 branch size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants