Draft
Conversation
on3iro
commented
Jun 25, 2023
| <Suspense fallback={<Loader size="large" />}> | ||
| <Suspense | ||
| fallback={<Loader size="large" />} | ||
| children={undefined} |
Author
There was a problem hiding this comment.
this should probably be fixed - my IDE showed me an error here, but shouldn't the div below technically be considered to be children? 🤔
Owner
|
Thanks @on3iro, I'll check it out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @itaditya ,
I tried to updated most dependencies and also updated the Root component type. This should fix the issues mentioned in #21 and #22 . However I didn't have much time and wasn't able to figure out why the audio checkbox in the demo page can't be clicked (which also makes a test fail).
It would be cool if you could give me a few pointers on where to look are if you would just take over from here :)
I haven't squashed my changes, yet, as I consider this to be a draft for now.
let me know, what you think.