fix: quote git push tag suggestions#502
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #114 by making the CLI’s “git push …” follow-up suggestions safe to copy/paste in shells when GTO-generated tag names contain shell-significant characters (e.g., #, !), by applying POSIX-style shell quoting.
Changes:
- Use
shlex.quote()when rendering the tag argument in the “To push the changes upstream…” suggestion output. - Update CLI regression tests to expect quoted suggestions for tags containing shell-significant characters.
- Preserve unquoted output for already shell-safe tag names (since
shlex.quote()leaves safe strings unchanged).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
gto/registry.py |
Quotes tag names in the printed git push suggestions via shlex.quote() to avoid shell parsing issues. |
tests/test_cli.py |
Updates expected CLI output strings to match the newly quoted git push suggestions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
shcheklein
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #114 by shell-quoting tag names in the
git pushsuggestions printed after creating/deleting GTO tags.Changes
shlex.quote()when rendering the suggested tag argument.a1@v0.0.1.#and!, e.g.git push origin 'nn1#prod#1'.Verification
pytest tests/test_cli.py::test_register tests/test_cli.py::test_assign -qpytest -qpython -m py_compile gto/*.pygit diff --check