Repository navigation
fix(i18n): improve Romanian translations - #2205
Merged
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanup of the Romanian locale in
packages/core/src/js/locale/ro.ts.Changed strings
searchEmptyStateNici un rezultat găsitNiciun rezultat găsitsearchSummaryAria(0)Nici un rezultat găsitNiciun rezultat găsitselectedCountryAriaLabelSchimbă țara pentru numărul de telefon, selectată ${countryName} (${dialCode})Schimbă țara pentru numărul de telefon, țara selectată: ${countryName} (${dialCode})Why
Left as is
searchSummaryAriaalready follows the CLDR rules forro(one, few, other): "1 rezultat găsit", "2 rezultate găsite", "20 de rezultate găsite", "101 rezultate găsite". I checked the output againstIntl.PluralRules("ro")for 0, 1, 2, 19, 20, 21, 100, 101, 119, 120, 219 and 245.Testing
npm run build:translations:gen: no changes to the generated files (locale/index.ts,locale/country-names/)npm run build: passes (includes lint and type checks)npm run test:js: 79 files, 692 tests passednpm run test:e2e: 25 passed, 17 skipped (the visual snapshot tests only run on Linux)