Skip to content

fix(i18n): improve Romanian translations - #2205

Merged
jackocnr merged 1 commit into
jackocnr:masterfrom
vicuts:fix/i18n-ro
Oct 11, 2026
Merged

jackocnr merged 1 commit into
jackocnr:masterfrom
vicuts:fix/i18n-ro

Conversation

@vicuts

@vicuts vicuts commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Small cleanup of the Romanian locale in packages/core/src/js/locale/ro.ts.

Changed strings

Key Before After
searchEmptyState Nici un rezultat găsit Niciun rezultat găsit
searchSummaryAria(0) Nici un rezultat găsit Niciun rezultat găsit
selectedCountryAriaLabel Schimbă țara pentru numărul de telefon, selectată ${countryName} (${dialCode}) Schimbă țara pentru numărul de telefon, țara selectată: ${countryName} (${dialCode})

Why

  • "Niciun" is the standard spelling of the adjective since DOOM2 (2005). "Nici un" written apart is only right when "un" is the numeral, as in "nici un rezultat, nici două", which is not the meaning here.
  • In the aria label, "selectată ${countryName}" reads like a broken fragment. With the change a screen reader says, for example, "Schimbă țara pentru numărul de telefon, țara selectată: Germania (+49)".

Left as is

  • The other strings already read naturally, so I did not touch them.
  • The plural logic in searchSummaryAria already follows the CLDR rules for ro (one, few, other): "1 rezultat găsit", "2 rezultate găsite", "20 de rezultate găsite", "101 rezultate găsite". I checked the output against Intl.PluralRules("ro") for 0, 1, 2, 19, 20, 21, 100, 101, 119, 120, 219 and 245.
  • The header comment is unchanged.

Testing

  • npm run build:translations:gen: no changes to the generated files (locale/index.ts, locale/country-names/)
  • npm run build: passes (includes lint and type checks)
  • npm run test:js: 79 files, 692 tests passed
  • npm run test:e2e: 25 passed, 17 skipped (the visual snapshot tests only run on Linux)

@jackocnr
jackocnr merged commit af82b40 into jackocnr:master Oct 11, 2026
1 check passed
@jackocnr

Copy link
Copy Markdown
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants