WIP: Introduce defineModule function to declare a module before registering#33
Open
mickmister wants to merge 1 commit intomainfrom
Open
WIP: Introduce defineModule function to declare a module before registering#33mickmister wants to merge 1 commit intomainfrom
defineModule function to declare a module before registering#33mickmister wants to merge 1 commit intomainfrom
Conversation
mickmister
commented
Jan 23, 2025
| import {Springboard} from 'springboard/engine/engine'; | ||
| import {springboard} from 'springboard/engine/register'; | ||
|
|
||
| const mod = springboard.defineModule('Main', { |
Member
Author
There was a problem hiding this comment.
We should then be able to do the following, even though it wouldn't make sense for a Main module:
declare module 'springboard' {
interface DefinedModules {
Main: typeof mod;
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make the initialization process more explicit, and facilitate dependency injection more easily, we are pivoting to explicit registering of modules instead of implicit registering through side effect imports.