This repository was archived by the owner on Oct 26, 2022. It is now read-only.
add resourceContainingJars key for ApkBuilder / prevent other projects are broken by GlobalScope#142
Open
lepidum wants to merge 4 commits intojberkel:masterfrom
Open
add resourceContainingJars key for ApkBuilder / prevent other projects are broken by GlobalScope#142lepidum wants to merge 4 commits intojberkel:masterfrom
lepidum wants to merge 4 commits intojberkel:masterfrom
Conversation
Make more precisely and customizable resource handling. For example, when I don't want to use proguard to unmanaged jars. useProguard in Android := true, dxInputs in Android <+= (unmanagedBase) map (x => x), Now, 'dx' command can handle directories properly, but ApkBuilder could not so. Because ApkBuilder requires that dxInputs contains files. Consequently, generated apk contains classes but does not contain resources.
add resourceContainingJars key for ApkBuilder
prevent other projects are broken by GlobalScope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add resourceContainingJars key for ApkBuilder
Make more precisely and customizable resource handling.
For example, when I don't want to use proguard to unmanaged jars.
Now, 'dx' command can handle directories properly, but ApkBuilder could not so.
Because ApkBuilder requires that dxInputs contains files.
Consequently, generated apk contains classes but does not contain resources.
prevent other projects are broken by GlobalScope
fix #141