Skip to content

feat: button icons disabled state #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arturbien wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: button icons disabled state #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 29 additions & 16 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,24 +18,37 @@ The easiest way to use 98.css is to import it from [unpkg](https://unpkg.com/).
```html
<!DOCTYPE html>
<html>
<head>
<title>98.css example</title>
<meta charset="UTF-8" />
<link rel="stylesheet" href="https://unpkg.com/98.css" />
</head>

<body>
<div class="window" style="margin: 32px; width: 250px">
<div class="title-bar">
<div class="title-bar-text">
My First VB4 Program
<head>
<title>98.css example</title>
<meta charset="UTF-8" />
<link rel="stylesheet" href="https://unpkg.com/98.css" />
</head>

<body>
<div class="window" style="margin: 32px; width: 250px">
<div class="title-bar">
<div class="title-bar-text">My First VB4 Program</div>
</div>
<div class="window-body">
<p>Hello, world!</p>
</div>
</div>
<div class="window-body">
<p>Hello, world!</p>
</div>
</div>
</body>

<svg id="filters-98css">
<defs>
<filter id="disabled-filter-98css">
<feColorMatrix
type="matrix"
values="1 0 0 0 0 0 1 0 0 0 0 0 1 0 0 -21.25 -71.54 -7.21 40 0"
result="color-matrix"
/>
<feFlood flood-color="grey" result="color" />
<feComposite in="color" in2="color-matrix" operator="in" />
<feDropShadow dx="1" dy="1" stdDeviation="0" flood-color="white" />
</filter>
</defs>
</svg>
</body>
</html>
```

Expand Down
28 changes: 28 additions & 0 deletions docs/index.html.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,19 @@
</p>

<%- example(`<button[[ class="focused"]]>I am focused</button>`) %>

<p>
Images and elements with <code>[role=img]</code> inside the button will get disabled state when the button is disabled.
</p>

<%- example(`
<button style="height: auto; padding: 16px;">
<img style="width: 32px;height: 32px;" src="mail-icon.png" alt="icon"/>
</button>
<button style="height: auto; padding: 16px;" disabled>
<img style="width: 32px;height: 32px;" src="mail-icon.png" alt="icon"/>
</button>
`) %>
</div>
</section>

Expand Down Expand Up @@ -987,5 +1000,20 @@
subscribing to more fun things on <a href="https://twitter.com/jdan">my twitter</a>. 👋
</p>
</main>

<svg id="filters-98css">
<defs>
<filter id="disabled-filter-98css">
<feColorMatrix
type="matrix"
values="1 0 0 0 0 0 1 0 0 0 0 0 1 0 0 -21.25 -71.54 -7.21 40 0"
result="color-matrix"
/>
<feFlood flood-color="grey" result="color" />
<feComposite in="color" in2="color-matrix" operator="in" />
<feDropShadow dx="1" dy="1" stdDeviation="0" flood-color="white" />
</filter>
</defs>
</svg>
</body>
</html>
Binary file added docs/mail-icon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 12 additions & 0 deletions style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,11 @@ input[type="reset"]:disabled,
text-shadow: 1px 1px 0 var(--button-highlight);
}

button:disabled img,
button:disabled [role="img"] {
filter: url("#disabled-filter-98css");
}

.window {
box-shadow: var(--border-window-outer), var(--border-window-inner);
background: var(--surface);
Expand Down Expand Up @@ -885,3 +890,10 @@ table > tbody > tr > * {
padding: 0 var(--grouped-element-spacing);
height: 14px;
}

#filters-98css {
position: absolute;
pointer-events: none;
top: 0;
left: 0;
}