Skip to content

Improve clicking in diff view to enter staging/patch building #3985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
stefanhaller wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

Improve clicking in diff view to enter staging/patch building #3985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
ed48988
Add LAZYGIT_SLOW_RENDER debug knob for watching async render frames
stefanhaller Jun 4, 2026
8a26beb
Add user config gui.showSelectionInFocusedMainView
stefanhaller Apr 1, 2025
fff7a0d
Press enter in focused main view when user config is on
stefanhaller Apr 1, 2025
1e5f31d
Select line that is in the middle of the screen
stefanhaller Mar 25, 2025
ed2015c
Press enter in main view of files/commitFiles to enter staging/patch-…
stefanhaller Sep 16, 2024
ec50f31
Extract some functions from CommitFilesController to a new CommitFile…
stefanhaller Oct 11, 2024
0088f26
Press enter in main view of commits panel to enter patch building for…
stefanhaller Oct 11, 2024
877812c
WIP After going straight to patch building from main view, esc goes a…
stefanhaller Mar 29, 2025
55922f8
Replace gui.showSelectionInFocusedMainView config with on-demand sele…
stefanhaller May 26, 2026
c5dd8dd
Press `e` in focused main view (when selection is showing) to edit th…
stefanhaller May 31, 2026
385d2e9
Open a browser at the selected line in the diff of the current branch…
stefanhaller May 31, 2026
207927e
WIP New click behavior
stefanhaller May 31, 2026
5f50089
WIP FocusedMainViewSnapshot approach
stefanhaller Jun 3, 2026
63221c3
Session notes
stefanhaller Jun 3, 2026
788d959
Lock the view and guard the line index when reading a hyperlink
stefanhaller Jun 4, 2026
b7470af
Don't scroll a view up to fill blank space while its content is loading
stefanhaller Jun 4, 2026
86f4b34
Fire queued ReadToEnd callbacks when the initial read reaches EOF
stefanhaller Jun 4, 2026
89e6f6b
Session notes: corrected flicker diagnosis and the 3 bug fixes
stefanhaller Jun 4, 2026
fe79d18
Route all view origin writes through SetOriginX and SetOriginY
stefanhaller Jun 4, 2026
7f547a5
Reset other main views' scroll after copying content, not before
stefanhaller Jun 4, 2026
054d139
Let a cmd/pty task restore a saved scroll position at its first paint
stefanhaller Jun 4, 2026
625e7db
Restore scroll and selection seamlessly when escaping to a focused ma…
stefanhaller Jun 4, 2026
f26a998
Session notes: escape flicker fix implemented; timing races remain
stefanhaller Jun 4, 2026
94313a6
Use the default select mode when diving into a patch explorer from a …
stefanhaller Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs-master/keybindings/Keybindings_en.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
| `` <mouse wheel up> (fn+down) `` | Scroll up | |
| `` <tab> `` | Switch view | Switch to other view (staged/unstaged changes). |
| `` <esc> `` | Exit back to side panel | |
| `` <space> `` | Show/hide selection | |
| `` / `` | Search the current view by text | |

## Main panel (patch building)
Expand Down Expand Up @@ -327,6 +328,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
|-----|--------|-------------|
| `` <tab> `` | Switch view | Switch to other view (staged/unstaged changes). |
| `` <esc> `` | Exit back to side panel | |
| `` <space> `` | Show/hide selection | |
| `` / `` | Search the current view by text | |

## Stash
Expand Down
2 changes: 2 additions & 0 deletions docs-master/keybindings/Keybindings_ja.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
|-----|--------|-------------|
| `` <tab> `` | ビューを切り替え | 他のビュー（ステージされた変更/ステージされていない変更）に切り替えます。 |
| `` <esc> `` | サイドパネルに戻る | |
| `` <space> `` | Show/hide selection | |
| `` / `` | 現在のビューをテキストで検索 | |

## タグ
Expand Down Expand Up @@ -305,6 +306,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
| `` <mouse wheel up> (fn+down) `` | 上にスクロール | |
| `` <tab> `` | ビューを切り替え | 他のビュー（ステージされた変更/ステージされていない変更）に切り替えます。 |
| `` <esc> `` | サイドパネルに戻る | |
| `` <space> `` | Show/hide selection | |
| `` / `` | 現在のビューをテキストで検索 | |

## メニュー
Expand Down
2 changes: 2 additions & 0 deletions docs-master/keybindings/Keybindings_ko.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
|-----|--------|-------------|
| `` <tab> `` | 패널 전환 | Switch to other view (staged/unstaged changes). |
| `` <esc> `` | Exit back to side panel | |
| `` <space> `` | Show/hide selection | |
| `` / `` | 검색 시작 | |

## Stash
Expand Down Expand Up @@ -161,6 +162,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
| `` <mouse wheel up> (fn+down) `` | 위로 스크롤 | |
| `` <tab> `` | 패널 전환 | Switch to other view (staged/unstaged changes). |
| `` <esc> `` | Exit back to side panel | |
| `` <space> `` | Show/hide selection | |
| `` / `` | 검색 시작 | |

## 메인 패널 (Patch Building)
Expand Down
2 changes: 2 additions & 0 deletions docs-master/keybindings/Keybindings_nl.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
| `` <mouse wheel up> (fn+down) `` | Scroll omhoog | |
| `` <tab> `` | Ga naar een ander paneel | Switch to other view (staged/unstaged changes). |
| `` <esc> `` | Exit back to side panel | |
| `` <space> `` | Show/hide selection | |
| `` / `` | Start met zoeken | |

## Patch bouwen
Expand Down Expand Up @@ -305,6 +306,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
|-----|--------|-------------|
| `` <tab> `` | Ga naar een ander paneel | Switch to other view (staged/unstaged changes). |
| `` <esc> `` | Exit back to side panel | |
| `` <space> `` | Show/hide selection | |
| `` / `` | Start met zoeken | |

## Staging
Expand Down
2 changes: 2 additions & 0 deletions docs-master/keybindings/Keybindings_pl.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
|-----|--------|-------------|
| `` <tab> `` | Przełącz widok | Przełącz na inny widok (zatwierdzone/niezatwierdzone zmiany). |
| `` <esc> `` | Exit back to side panel | |
| `` <space> `` | Show/hide selection | |
| `` / `` | Szukaj w bieżącym widoku po tekście | |

## Drzewa pracy
Expand Down Expand Up @@ -200,6 +201,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
| `` <mouse wheel up> (fn+down) `` | Przewiń w górę | |
| `` <tab> `` | Przełącz widok | Przełącz na inny widok (zatwierdzone/niezatwierdzone zmiany). |
| `` <esc> `` | Exit back to side panel | |
| `` <space> `` | Show/hide selection | |
| `` / `` | Szukaj w bieżącym widoku po tekście | |

## Panel główny (scalanie)
Expand Down
2 changes: 2 additions & 0 deletions docs-master/keybindings/Keybindings_pt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
| `` <mouse wheel up> (fn+down) `` | Rolar para cima | |
| `` <tab> `` | Mudar de visão | Alternar para outra visão (staged/não processadas alterações). |
| `` <esc> `` | Exit back to side panel | |
| `` <space> `` | Show/hide selection | |
| `` / `` | Pesquisar na visualização atual por texto | |

## Painel Principal (preparação)
Expand Down Expand Up @@ -336,6 +337,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
|-----|--------|-------------|
| `` <tab> `` | Mudar de visão | Alternar para outra visão (staged/não processadas alterações). |
| `` <esc> `` | Exit back to side panel | |
| `` <space> `` | Show/hide selection | |
| `` / `` | Pesquisar na visualização atual por texto | |

## Stash
Expand Down
2 changes: 2 additions & 0 deletions docs-master/keybindings/Keybindings_ru.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
|-----|--------|-------------|
| `` <tab> `` | Переключиться на другую панель (проиндексированные/непроиндексированные изменения) | Switch to other view (staged/unstaged changes). |
| `` <esc> `` | Exit back to side panel | |
| `` <space> `` | Show/hide selection | |
| `` / `` | Найти | |

## Главная панель (Индексирование)
Expand Down Expand Up @@ -105,6 +106,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
| `` <mouse wheel up> (fn+down) `` | Прокрутить вверх | |
| `` <tab> `` | Переключиться на другую панель (проиндексированные/непроиндексированные изменения) | Switch to other view (staged/unstaged changes). |
| `` <esc> `` | Exit back to side panel | |
| `` <space> `` | Show/hide selection | |
| `` / `` | Найти | |

## Главная панель (Слияние)
Expand Down
2 changes: 2 additions & 0 deletions docs-master/keybindings/Keybindings_zh-CN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
|-----|--------|-------------|
| `` <tab> `` | 切换到其他面板 | 切换到其他视图（已暂存/未暂存的变更） |
| `` <esc> `` | 退出回到侧边面板 | |
| `` <space> `` | Show/hide selection | |
| `` / `` | 开始搜索 | |

## 正在合并
Expand Down Expand Up @@ -333,6 +334,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
| `` <mouse wheel up> (fn+down) `` | 向上滚动 | |
| `` <tab> `` | 切换到其他面板 | 切换到其他视图（已暂存/未暂存的变更） |
| `` <esc> `` | 退出回到侧边面板 | |
| `` <space> `` | Show/hide selection | |
| `` / `` | 开始搜索 | |

## 状态
Expand Down
2 changes: 2 additions & 0 deletions docs-master/keybindings/Keybindings_zh-TW.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
| `` <mouse wheel up> (fn+down) `` | 向上捲動 | |
| `` <tab> `` | 切換至另一個面板 (已預存/未預存更改) | Switch to other view (staged/unstaged changes). |
| `` <esc> `` | Exit back to side panel | |
| `` <space> `` | Show/hide selection | |
| `` / `` | 搜尋 | |

## 主面板（合併）
Expand Down Expand Up @@ -362,6 +363,7 @@ _This file is auto-generated. To update, make the changes in the pkg/i18n direct
|-----|--------|-------------|
| `` <tab> `` | 切換至另一個面板 (已預存/未預存更改) | Switch to other view (staged/unstaged changes). |
| `` <esc> `` | Exit back to side panel | |
| `` <space> `` | Show/hide selection | |
| `` / `` | 搜尋 | |

## 狀態
Expand Down
Loading
Loading