Add new fields to analytics event v3 - #1403
Open
eranturgeman wants to merge 9 commits into
Open
Conversation
eranturgeman
commented
Aug 5, 2026
eranturgeman
commented
Collaborator
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
- Update documentation about new features / new supported technologies
…SendScanEndedEvent-function # Conflicts: # go.mod # go.sum # scanrepository/scanrepository.go
…fields-to-analytics-event-v3
eranturgeman
added
safe to test
github-actions
Bot
removed
the
safe to test
attiasas
reviewed
Aug 6, 2026
attiasas
left a comment
attiasas
left a comment
Contributor
There was a problem hiding this comment.
you only updated the deps, should you inject the new values here?
Collaborator
Author
You are correct this is confusing, but in a previous PR I moved V3 to use SendScanEndedWithResults instead of SendScanEndedEvent. this is "automatically" completes it as the new fields we need are already in cmdResults and they are passed to the updated version of SendScanEndedEvent. so we just had to update the dependency of the security-cli and client-go here |
…fields-to-analytics-event-v3 # Conflicts: # go.mod # go.sum
eranturgeman
added
the
safe to test
github-actions
Bot
removed
the
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.