Parse first User-Agent product segment for product_id and version - #3662
Merged
Conversation
Rich jfrog-skills UAs no longer collapse product_version to the trailing jfrog-cli-go version. HTTP keeps the raw JFROG_CLI_USER_AGENT string so Coralogix request-log parsing stays unchanged.
Drops the raw HTTP User-Agent passthrough and ai-* dedup, which were not needed to fix product_id/product_version for long user agents.
Skill/hook path is not sent to Visibility; the plugin UA keeps the trigger= parens (Coralogix only). First-token product_id/version parse is unchanged.
yahavi
reviewed
Aug 13, 2026
Member
There was a problem hiding this comment.
🤖 Review comment by Cursor AI
✅ All findings have been resolved.
- Uses
strings.Cutfor the first User-Agent segment - Preserves the full raw User-Agent on HTTP / Call Home while Visibility uses only the first product segment
- Existing AI suffix behavior remains unchanged
yahavi
reviewed
Aug 13, 2026
yahavi
reviewed
Aug 13, 2026
Restore cliUserAgentRaw passthrough so HTTP/Call Home keep trigger= and trailing tokens, while Visibility still parses the first product token. Also use strings.Cut for the space trim.
Keep only the raw-wire preservation required by first-segment Visibility parsing; remove the unrelated ai-* dedup change and avoid credential-like terminology for UA segments.
sverdlov93
changed the title
sverdlov93
enabled auto-merge (squash)
August 14, 2026 07:48
yahavi
approved these changes
Aug 14, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Visibility
product_id/product_versionfor long User-Agent strings fromjfrog-skills/jfrog-agent-hooksby parsing the first whitespace-delimited product segment (name/version).This preserves existing behavior everywhere else: HTTP and Call Home keep the full raw
JFROG_CLI_USER_AGENT, and the existing AI suffix behavior is unchanged.Example
jfrog-skills/0.22.0 (trigger=skill; …) jfrog-cli-go/2.120.0product_id=jfrog-skills,product_version=0.22.0Related
client/model)