Walkthrough UX polish: collapsible Apply readiness summary + unified Change display title - #284
Merged
Merged
Conversation
… unify the Change display title Owner walkthrough round on the OpenSpecUI 13 acceptance instance: 1. Apply warnings/build-order notices consumed the Change Detail page. ApplyProgressNotice now renders one always-visible summary row (warning count + full build-order chain + CLI attribution, role=status, collapsed by default); one explicit expansion reveals the verbatim upstream evidence on the same direct plane. Divergence stays a direct block. Spec delta updated to codify the summary-row contract. 2. The Changes list titled rows with the generic scaffold heading "# Proposal" while Change Detail used the change id. New shared changeDisplayTitle(id, name): an informative proposal heading wins, generic/blank/id-equal values fall back to the change id — wired into the Changes list, Dashboard rows, and the Change Detail header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes from the Owner's acceptance walkthrough of the OpenSpecUI 13 instance:
Apply readiness guidance no longer consumes the page. The always-expanded warnings/build-order blocks are now ONE always-visible summary row — warning count + the full build-order chain +
openspec instructions applyattribution (role="status", collapsed by default). One explicit expansion reveals the verbatim upstream evidence on the same direct plane; Tooltip-only remains forbidden, and the divergence notice keeps its direct uncollapsed block. The change's spec delta (Apply Readiness Guidance Surface) is updated to codify the summary-row contract.One Change title everywhere. The Changes list titled rows with the legacy parser's proposal H1 (the scaffold's generic
# Proposal), while Change Detail used the CLI status name (= id). New sharedchangeDisplayTitle(id, name)in the web lib: an informative proposal heading wins; generic/blank/id-equal values fall back to the change id. Wired into the Changes list rows + VT handoff, Dashboard rows, and the Change Detail header (rows name with the status name as pre-rows fallback).Evidence
specs → design; expansion reveals verbatim evidence; Changes list row titles read["no-specs-but-tasks","fresh-blocked-change"](no generic "Proposal"); Detail header shows the same id title.main— unrelated to this change's files.Notes
http://localhost:3517already serves the rebuilt assets for re-walkthrough.@openspecui/webpatch.