Stuck#9
Open
schenlap wants to merge 3 commits into
Open
Conversation
lucaceresoli
approved these changes
May 3, 2022
lucaceresoli
left a comment
lucaceresoli
left a comment
Contributor
There was a problem hiding this comment.
Thanks @schenlap .
Looks good!
jnavila
requested changes
Jun 21, 2022
jnavila
left a comment
jnavila
left a comment
Owner
There was a problem hiding this comment.
A few details. Sorry for some comments about splitting into commits, I was reading the full diff.
| #define EXIT_FAIL_OTHERTEST 0x04 | ||
|
|
||
| struct test tests[] = { | ||
| { "Stuck Address", test_stuck_address }, |
Owner
There was a problem hiding this comment.
Why don't you add Stuck Address at the end of the array instead of shift the indices of the other tests in the testmask?
| o_flags &= ~O_SYNC; | ||
| break; | ||
| o_flags &= ~O_SYNC; | ||
| break; |
Owner
There was a problem hiding this comment.
You are mixing changes for different purposes here. Is it your editor changing the indentation?
| } | ||
|
|
||
| int test_stuck_address(ulv *bufa, size_t count) { | ||
| int test_stuck_address(ulv *bufa, ulv *bufb, size_t count) { |
Owner
There was a problem hiding this comment.
bufb is not used; then add a "(void)bufb;" line to muffle the compiler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow masking stuck address test, add error counter