-
Notifications
You must be signed in to change notification settings - Fork 9
fix: suppress oclif TypeScript warning with NODE_ENV=production #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Set NODE_ENV=production before importing @oclif/core - This prevents oclif from attempting TypeScript detection in production - Reverted previous complex solution in favor of this simpler approach - Tested with tsconfig.json in current directory - no warnings 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
WalkthroughThe script in Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learningsbin/run.js (3)⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
🔇 Additional comments (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
🎉 This PR is included in version 1.5.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Problem
The previous fix didn't work because the warning is triggered during the import of
@oclif/core, before theexecute()function is called.Solution
Set
process.env.NODE_ENV = 'production'before importing @oclif/core. This prevents oclif from checking for TypeScript in production environments.Test Plan
node bin/run.js help- no warning🤖 Generated with Claude Code
Summary by CodeRabbit