Open
Conversation
Contributor
|
I would rename AuthenticateUser to Authenticate and add it to channel. Since it requires channel name as the first arg, it makes more sense on channel to me. I also would like to see this library line up closely with the pusher ruby gem as I have found it to be pleasant to work with in the past. |
Contributor
|
We will probably have to pass an instance of the client to the channel then, so we have the key/secret and a way to make other client requests, but that seems fine. |
add channelAuthenticate example
Author
|
I've renamed and added the Authenticate method to Channel. I've created a new example file channelAuthenticate, which loads pusher package locally instead of git repo, I guess it could help to fix examples. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposition to add user authentication based on http://pusher.com/docs/auth_signatures for issue #2
Maybe AuthenticateUser method could be added to Channel instead of Client like the pusher ruby gem (https://github.com/pusher/pusher-gem/blob/master/lib/pusher/channel.rb#L139).