Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 86.03% 86.34% +0.30%
==========================================
Files 1 1
Lines 2342 2343 +1
==========================================
+ Hits 2015 2023 +8
+ Misses 327 320 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gprof can list a function that its static call graph analysis discovered but that never got its own call graph entry. When GprofParser.parse meets one of those as a child it builds a placeholder Function, but writes the self time and call count onto the caller (function[TIME], function.called) instead of the placeholder, so the caller's real numbers are wiped and the placeholder goes in with no TIME event. profile.ratio(TIME_RATIO, TIME) then trips its assert on that placeholder and the whole run dies; AXEParser.parse holds a copy of the same code with the same misassignment.
Point both assignments at the placeholder (missing) so it carries the events it needs and the caller keeps its own. AXE functions also hold a total-time ratio, so the placeholder there gets TOTAL_TIME_RATIO too, which the later call-weight pass reads. The branch only runs for functions with no entry, so profiles that never reach it come out unchanged.