Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 86.03% 87.05% +1.01%
==========================================
Files 1 1
Lines 2342 2341 -1
==========================================
+ Hits 2015 2038 +23
+ Misses 327 303 -24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Pushed a test for the codecov/patch failure: a collapse fixture with two functions named foo and a --root=foo run in test.py, diffed against a committed reference, so the new matching path is covered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getFunctionIds collapses every function into a {name: id} dict before matching, so two functions that share a name but have distinct ids (the same symbol in different modules, which happens in perf, dtrace, sleepy and collapse-with-source input) fold to one entry and only the last survives. Selecting that name with --root or --leaf then keeps one of the subtrees and quietly drops the others.
Match against each function name directly and return every id that matches, so a name or glob that resolves to several functions yields all of them. Keeping this in getFunctionIds means prune_root and prune_leaf both receive the full root/leaf set without either caller having to know that names can repeat.