Enhance CSSStyleDeclaration constructor options#316
Open
asamuzaK wants to merge 3 commits intojsdom:mainfrom
Open
Enhance CSSStyleDeclaration constructor options#316asamuzaK wants to merge 3 commits intojsdom:mainfrom
asamuzaK wants to merge 3 commits intojsdom:mainfrom
Conversation
Contributor
Author
|
This would probably be a breaking change since it changes how |
Contributor
Author
Done above. |
asamuzaK
force-pushed
the
constructor
branch
2 times, most recently
from
f7f30f2 to
4577cd4
Compare
domenic
reviewed
Mar 2, 2026
lib/CSSStyleDeclaration.js
Outdated
|
|
||
| // TODO: Add private method to prepare options. | ||
| // Options for computed style. | ||
| this._computedStyleOpts = null; |
Member
There was a problem hiding this comment.
Can you remove this for now, at least until something is actually using it?
Removed TODO comment for private method to prepare options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepting a globalObject as the first argument, args as the second, and private options such as computed, fontSizeMedium, onChangeCallback, and systemColors as the third, and initializing the relevant internal fields.