chore: switch version.go to inline release-please marker#106
Merged
Conversation
Block marker (start/end) requires a blank line before the end-marker comment under gofmt, which conflicts with our desire to keep the marker block dense. The inline single-line variant works for release-please and is naturally gofmt/gofumpt compliant without any nolint directives. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jun06t
force-pushed
the
chore/inline-version-annotation
branch
from
317b6eb to
31d6a51
Compare
jun06t
changed the title
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
block marker (
x-release-please-start-version/x-release-please-end) ではなく、行末注釈// x-release-please-version1 行に切り替える。block marker は const と end-marker コメントの間に gofmt が空行を要求するため、運用上のノイズになる。行末注釈の単一行マーカーなら自然な Go コードのまま release-please の自動 bump も動く。
検証ゴール
マージ後、release-please workflow が走り:
BuildVersionが次バージョンに自動書き換わる（行末注釈でも置換が機能することの確認）