feat: scaffold BuildVersion constant for release-please marker test#98
Merged
Conversation
Add x-release-please-start-version marker block in unary/metadata/keepalive server and client binaries. Register the marker files in extra-files so that release-please rewrites BuildVersion on each Release PR. The constant is intended to be referenced from observability code paths (Cloud Profiler / OpenTelemetry) as service.version metadata. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
各 component (unary / metadata / keepalive) の server / client バイナリに
BuildVersion定数を追加し、release-please のバージョンマーカーで囲む。release-please-config.jsonの各 package にextra-filesを登録し、Release PR 作成時に release-please が自動でBuildVersionを次バージョンに書き換える形にする。将来的に Cloud Profiler / OpenTelemetry の
service.versionとして参照する想定。Phase 1 検証ゴール
このマージ後に Release Please workflow が走り、以下が観測できることを確認したい:
unary,metadata,keepaliveそれぞれに Release PR が立つ（path filter で発火）server/version.goとclient/version.goのBuildVersion行が新バージョンへ書き換わっているNotes
各 component の version.go を実際に touch しているので path filter だけで全 component が発火する。各 CHANGELOG には PR タイトルがそのまま入る想定。