seaweedfs: init#689
Open
kashw2 wants to merge 1 commit into
Open
Conversation
shivaraj-bh
reviewed
Jun 1, 2026
Member
|
just a meta note: good to see an alternative since I had to 64f5794 |
shivaraj-bh
reviewed
Jun 2, 2026
| # Below generates curl checks for all endpoints separated by && | ||
| lib.concatStringsSep " && " ( | ||
| [ | ||
| (check "http://${config.host}:${toString config.master.port}/cluster/status") |
Member
There was a problem hiding this comment.
upstream e2e docker image uses /cluster/healthz and /healthz (for volume). https://github.com/seaweedfs/seaweedfs/blob/38a47d1dd39a024d6d32fe5a934c73d93b943859/docker/compose/e2e-mount.yml#L8
any reason /status is used here?
Contributor
Author
There was a problem hiding this comment.
In my original implementation I was trying to have more sophisticated tests that involved more than just testing if a request succeeded and checking responses with grep. It might have been something from then that continued to work after I abandoned that decision in favor of just testing against whether or not a request worked or not. I'll swap it to be inline with upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds SeaweedFS. A MinIO alternative