chore: add android/libs and ios/Frameworks to .npmignore#231
Open
chore: add android/libs and ios/Frameworks to .npmignore#231
Conversation
Both directories hold local-dev binaries (SDK AARs and JWPlayerKit.xcframework) that are opt-in via $RNJWPlayerUseLocalSDK / useLocalAARs. They are not tracked in git, but were being swept into npm pack from the working tree. Confirmed during the 1.5.0 publish: a pre-pack dry-run was 25 MB / 200 files vs 1.4.1's 464 KB / 36 files. After moving the local binaries aside the tarball dropped back to the expected size and 1.5.0 was published clean. This change prevents recurrence if anyone still has those binaries present at publish time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Adds
android/libsandios/Frameworksto.npmignoreso local-dev SDK binaries can't leak into futurenpm publishtarballs.Why is this Pull Request needed?
Both directories are opt-in local-dev paths (
\$RNJWPlayerUseLocalSDKfor iOS,useLocalAARsfor Android). They're not tracked in git, butnpm packpacks from the working tree — so if the binaries are present at publish time, they get shipped.This was caught during the v1.5.0 publish: the initial
npm publish --dry-runwas 25 MB / 200 files vs v1.4.1's published 464 KB / 36 files. After moving the local binaries aside, the tarball dropped back to the expected size and v1.5.0 shipped clean. This patch makes the protection permanent.Are there any points in the code the reviewer needs to double check?
.npmignoreentries don't collide with any intended published path. Neitherandroid/libsnorios/Frameworksis tracked in git, so there is nothing legitimate to exclude.Are there any Pull Requests open in other repos which need to be merged with this?
No.