[release/0.16] Fix old job replacement - #340
Merged
brandond merged 2 commits intoJul 17, 2026
Merged
Conversation
The controller would never replace jobs created by older versions of helm-controller that hadn't been suspended. We now reenqueue replacement until the job has no running pods, and suspend the job to cleanly stop pods before deleting it. There are also new tests to validate replacement of old failed and successful jobs. Signed-off-by: Brad Davidson <brad.davidson@rancher.com> (cherry picked from commit cbea780) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com> (cherry picked from commit f6dd056) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
changed the title
matttrach
approved these changes
Jul 16, 2026
vitorsavian
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport: