Feat: Example of how a Kubernetes deployment with labels to appear in Kagenti UI#186
Conversation
…ti UI Signed-off-by: Ed Snible <snible@us.ibm.com>
Signed-off-by: Ed Snible <snible@us.ibm.com>
pdettori
left a comment
There was a problem hiding this comment.
Good example manifest — well-structured with helpful comments. A few suggestions:
1. managed-by: kagenti-e2e label is misleading for a user-facing example
The app.kubernetes.io/managed-by: kagenti-e2e label on both the Service and Deployment suggests this is E2E test infrastructure. Users copying this manifest will inherit that. Consider changing to something like kagenti-example or removing it, since this is a reference manifest, not a test fixture.
2. Orphan marvin volume
The marvin volume is declared in volumes: but its corresponding volumeMount is commented out. This creates an unused volume. Either comment out both or remove the volume definition entirely:
# Uncomment if the Agent has a Marvin dependency
# - emptyDir: {}
# name: marvin3. Consider showing Secret references for API keys
The dummy values are fine for local dev, but since this is a best-practice example, it would be helpful to show a commented-out Secret reference pattern alongside the hardcoded values:
# For production, use a Secret:
# - name: OPENAI_API_KEY
# valueFrom:
# secretKeyRef:
# name: llm-credentials
# key: openai-api-key4. Empty securityContext: {}
For a reference manifest, consider adding runAsNonRoot: true or a restrictive pod security context to model good practice.
None of these are blockers — nice addition to the examples. 👍
Signed-off-by: Ed Snible <snible@us.ibm.com>
|
I have addressed the comments. |
Summary
This PR introduces an example of K8s Deployment manifests for an A2A agent
Related issue(s)
None.
(Optional) Testing Instructions